Add --dump-fir option to ChiselStage #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Aug 3, 2023
|
|
||
| info("The exception should not contain a stack trace") | ||
| exception.getStackTrace should be(Array()) | ||
| } |
jackkoenig
force-pushed
the
jackkoenig/chiselstage-dump-fir
branch
from
7123fcc
to
f03d097
Compare
This option will dump the .fir before invoking firtool. Additional changes: * Use os.lib for invoking firtool * Use lazy serialization to avoid holding the entire FIRRTL in memory. * Mix NoStackTrace into FirtoolNotFound * Fix detection of no firtool
jackkoenig
force-pushed
the
jackkoenig/chiselstage-dump-fir
branch
from
f03d097
to
131a702
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
This option will dump the .fir before invoking firtool. Additional changes: * Use os.lib for invoking firtool * Use lazy serialization to avoid holding the entire FIRRTL in memory. * Mix NoStackTrace into FirtoolNotFound * Fix detection of no firtool (cherry picked from commit 4db86b2) # Conflicts: # src/main/scala/circt/stage/CIRCTOptions.scala # src/main/scala/circt/stage/ChiselStage.scala # src/main/scala/circt/stage/phases/CIRCT.scala
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
This option will dump the .fir before invoking firtool. Additional changes: * Use os.lib for invoking firtool * Use lazy serialization to avoid holding the entire FIRRTL in memory. * Mix NoStackTrace into FirtoolNotFound * Fix detection of no firtool (cherry picked from commit 4db86b2) # Conflicts: # src/main/scala/circt/stage/CIRCTOptions.scala # src/main/scala/circt/stage/ChiselStage.scala # src/main/scala/circt/stage/phases/CIRCT.scala
This was referenced Aug 3, 2023
jackkoenig
added a commit
that referenced
this pull request
Nov 16, 2023
This option will dump the .fir before invoking firtool. Additional changes: * Use os.lib for invoking firtool * Use lazy serialization to avoid holding the entire FIRRTL in memory. * Mix NoStackTrace into FirtoolNotFound * Fix detection of no firtool (cherry picked from commit 4db86b2) # Conflicts: # src/main/scala/circt/stage/CIRCTOptions.scala # src/main/scala/circt/stage/ChiselStage.scala # src/main/scala/circt/stage/phases/CIRCT.scala
mergify bot
added a commit
that referenced
this pull request
Nov 16, 2023
* Add --dump-fir option to ChiselStage (#3453) This option will dump the .fir before invoking firtool. Additional changes: * Use os.lib for invoking firtool * Use lazy serialization to avoid holding the entire FIRRTL in memory. * Mix NoStackTrace into FirtoolNotFound * Fix detection of no firtool (cherry picked from commit 4db86b2) # Conflicts: # src/main/scala/circt/stage/CIRCTOptions.scala # src/main/scala/circt/stage/ChiselStage.scala # src/main/scala/circt/stage/phases/CIRCT.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, a 20 min hack had a bit of scope creep but I think this is a nice improvement
I'm open to a better name for the argument, but I think the functionality is pretty handy
@fabianschuiki FYI
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
This option will dump the .fir before invoking firtool.
Reviewer Checklist (only modified by reviewer)
3.5.x,3.6.x, or5.xdepending on impact, API modification or big change:6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.