Add support for String Property type and literal. #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes support for Property[String] and literals.
seldridge
approved these changes
Aug 15, 2023
| @@ -110,6 +110,8 @@ object Serializer { | |||
| b ++= "SInt"; s(width); b ++= "(0h"; b ++= value.toString(16); b ++= ")" | |||
| case IntegerPropertyLiteral(value) => | |||
| b ++= "Integer("; b ++= value.toString(10); b ++= ")" | |||
| case StringPropertyLiteral(value) => | |||
| b ++= "String(\""; b ++= value; b ++= "\")" | |||
There was a problem hiding this comment.
I had thought there would be a cleaner way of expressing this. However, the alternative actually looks worse:
Suggested change
| b ++= "String(\""; b ++= value; b ++= "\")" | |
| b ++= """String(""""; b ++= value; b ++= """")""" |
Let's keep this as-is. 😉
jackkoenig
approved these changes
Aug 16, 2023
|
maybe https://github.com/chipsalliance/chisel/blob/master/src/main/scala/chisel3/util/circt/PlusArgsValue.scala can also output a String Property? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x,3.6.x, or5.xdepending on impact, API modification or big change:6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.