Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for probe and Decoupled interaction + demo of workaround #3558

Merged
merged 2 commits into from Sep 27, 2023

Conversation

debs-sifive
Copy link
Contributor

@debs-sifive debs-sifive commented Sep 27, 2023

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Coerces tapAndRead to punch stripped-direction flips when punching downwards with Inward non-probe ports, Fixes #3556

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@debs-sifive debs-sifive added the Bugfix Fixes a bug, will be included in release notes label Sep 27, 2023
@mwachs5
Copy link
Contributor

mwachs5 commented Sep 27, 2023

Fixes #3556

@mwachs5
Copy link
Contributor

mwachs5 commented Sep 27, 2023

what milestone should this be? 6.0?

@debs-sifive debs-sifive added this to the 6.0 milestone Sep 27, 2023
@debs-sifive debs-sifive merged commit a04cb2e into main Sep 27, 2023
15 checks passed
@debs-sifive debs-sifive deleted the probe-decoupled branch September 27, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect FIRRTL for BoringUtils upwards read
2 participants