Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isLit for Property types. #3782

Merged
merged 1 commit into from Jan 30, 2024
Merged

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Since we override litOption to always be None, we need to override isLit to check the Binding.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Since we override litOption to always be None, we need to override
isLit to check the Binding.
@mikeurbach mikeurbach added the Feature New feature, will be included in release notes label Jan 30, 2024
@mikeurbach
Copy link
Contributor Author

I'm not sure what to do with milestones now that 6.0 has branched. Should this be tagged with 6.x or 7.0?

@mwachs5
Copy link
Contributor

mwachs5 commented Jan 30, 2024

Should this be tagged with 6.x or 7.0?

If it is not API-breaking it should be tagged 6.x (new features/APIs are OK). If it will not be binary compatible (you are changing or deleting an existing API) mark it with 7.0

@mikeurbach mikeurbach added this to the 6.x milestone Jan 30, 2024
@mikeurbach mikeurbach merged commit 7be47bb into main Jan 30, 2024
17 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/property-is-lit branch January 30, 2024 18:46
@mergify mergify bot added the Backported This PR has been backported label Jan 30, 2024
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
Since we override litOption to always be None, we need to override
isLit to check the Binding.

(cherry picked from commit 7be47bb)
chiselbot pushed a commit that referenced this pull request Jan 30, 2024
Since we override litOption to always be None, we need to override
isLit to check the Binding.

(cherry picked from commit 7be47bb)

Co-authored-by: Mike Urbach <mike.urbach@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants