Add JsonProtocol.serializeRecover #2227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function will safely wrap any unserializeable annotations in
UnserializeableAnnotations so that they can be safely serialized to JSON
for logging.
Follow on to #1885, makes
-ll trace
much more useful if you happen to have 1 unserializable annotation making your whole log worthless.Contributor Checklist
Type of Improvement
API Impact
There is a new public method,
JsonProtocol.serializeRecover
which will always succeed because it wraps any unserializable annotations inUnserializableAnnotations
with the error and.toString
of the underlyingAnnotation
as contents.Backend Code Generation Impact
None
Desired Merge Strategy
Release Notes
JsonProtocol.serializeRecover
which wraps unserializable annotations inUnserializableAnnotations
so that a valid JSON is always created.--log-level trace
so that the logged annotations are always useful, even when there are unserializable annotationsReviewer Checklist (only modified by reviewer)
Please Merge
?