Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect deprecation warning for TargetDirAnnotation #2511

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix incorrect deprecation warning for TargetDirAnnotation #2511

merged 1 commit into from
Apr 11, 2022

Conversation

jackkoenig
Copy link
Contributor

Given this has been deprecated for a very long time, we should delete it, but we should at least fix the warning for most branches

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • [NA] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Fix incorrect deprecation warning for TargetDirAnnotation

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 1.3.x milestone Apr 11, 2022
@jackkoenig jackkoenig merged commit 06ccf51 into master Apr 11, 2022
@jackkoenig jackkoenig deleted the fix-deprecation-warning branch April 11, 2022 22:28
mergify bot pushed a commit that referenced this pull request Apr 11, 2022
@jackkoenig
Fix incorrect deprecation warning for TargetDirAnnotation (#2511)
9ca1a7b 
(cherry picked from commit 06ccf51)

# Conflicts:
#	src/main/scala/firrtl/package.scala
@mergify mergify bot mentioned this pull request Apr 11, 2022
Merged
mergify bot pushed a commit that referenced this pull request Apr 11, 2022
@jackkoenig
Fix incorrect deprecation warning for TargetDirAnnotation (#2511)
b96193c 
(cherry picked from commit 06ccf51)
@mergify mergify bot mentioned this pull request Apr 11, 2022
Merged
mergify bot pushed a commit that referenced this pull request Apr 11, 2022
@jackkoenig
Fix incorrect deprecation warning for TargetDirAnnotation (#2511)
0d37b08 
(cherry picked from commit 06ccf51)
@mergify mergify bot mentioned this pull request Apr 11, 2022
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Apr 11, 2022
mergify bot added a commit that referenced this pull request Apr 11, 2022
@mergify @jackkoenig
Fix incorrect deprecation warning for TargetDirAnnotation (#2511) (#2513
ce3c317 
)

(cherry picked from commit 06ccf51)

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Apr 11, 2022
@mergify @jackkoenig
Fix incorrect deprecation warning for TargetDirAnnotation (#2511) (#2514
90fab5a 
)

(cherry picked from commit 06ccf51)

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Apr 11, 2022
@mergify @jackkoenig
Fix incorrect deprecation warning for TargetDirAnnotation (backport #…
2ff74ab 
…2511) (#2512)

* Fix incorrect deprecation warning for TargetDirAnnotation (#2511)

(cherry picked from commit 06ccf51)

# Conflicts:
#	src/main/scala/firrtl/package.scala

* Resolve backport conflicts

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch
Projects
None yet
Milestone
1.3.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackkoenig @seldridge