Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BusWrapper API Update #1190

Merged
merged 17 commits into from Mar 1, 2018
Merged

BusWrapper API Update #1190

merged 17 commits into from Mar 1, 2018

Conversation

hcook
Copy link
Member

@hcook hcook commented Jan 12, 2018 •
edited

  • Rename coreplex => subsystem
  • New TLBusWrapper attachment API
  • Further tweaks to LazyModule instance name inference

@hcook hcook requested a review from aswaterman January 12, 2018 20:31
@hcook hcook requested a review from terpstra February 15, 2018 22:04
@hcook hcook changed the title Rename coreplex => subsystem BusWrapper API Update Feb 15, 2018
terpstra
terpstra approved these changes Feb 16, 2018
View reviewed changes
Copy link
Contributor

@terpstra terpstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have fun updating all the submodules...

@hcook
Copy link
Member Author

hcook commented Feb 16, 2018

Oh i will

@terpstra
Copy link
Contributor

My fear is module names will be very unstable now.

@hcook hcook merged commit 20a8876 into master Mar 1, 2018
@hcook hcook mentioned this pull request Mar 1, 2018
Closed
This was referenced Mar 1, 2018
Closed
Open
@edcote edcote mentioned this pull request Mar 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

@terpstra terpstra terpstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hcook @terpstra @aswaterman @DecodeTheEncoded @edcote