Switch to firrtl.stage.FirrtlMain #1984
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the underlying FIRRTL app from
firrtl.Driver
tofirrtl.stage.FirrtlStage
. For the purposes of Rocket Chip, these should be equivalent. The only things that I think could affect Rocket Chip is the removal of--top-name
and--split-modules
. Top name was really a convoluted way to specify an output file which Rocket Chip never used publicly as far as I'm aware. Use explicit options (as Rocket Chip does) to do that going forward:For the emitters, you get a default single-file emitter derived from the compiler. If you want a one-file-per-module emitter, use an explicit
-e/--emit-modules
emitter. In summary:Related Issue: chipsalliance/firrtl#1005
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes