Update APBtoTL scala to not flip apb address when doing conversion #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APB address is getting bitwise flipped to get TL address which then immediately fails the assertion that checks they are the same. Revert line that does the flip to previous version.
|
Sorry for closing and re-opening, thought I was mistaken |
jerryz123
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
APB address is getting bitwise flipped to get TL address which then immediately fails the assertion below that checks they are the same.
when (out.a.fire) { assert(in.paddr === out.a.bits.address, "Do not expect to have to perform alignment in APB2TL Conversion") }Reverts line back to before commit #3059