Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for chapter 7 #49

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2019

Add tests for chapter 7. It has missing tests for subsections 7.10.3 and 7.10.5.

@ghost ghost requested review from tgorochowik and piotr-binkowski August 30, 2019 13:43
Copy link
Member

@tgorochowik tgorochowik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that besides the tests you included a test generator with a template - does it generate additional tests, or are these the same ones that you included directly?

Could this test generator be based on #43 ? Or could you take a look at #43 to see if you would do anything differently? I think we need some kind of a convention for the test generators (and a makefile target).

@ghost
Copy link
Author

ghost commented Aug 30, 2019

All tests are generated from basic7.sv template.

Generator can be adapted to fit #43 and basic7.sv template can be moved to e.g. conf/generators/template-basic7.sv

Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
@ghost
Copy link
Author

ghost commented Sep 24, 2019

Pushed whole chapter-7 test suite.
It includes tests with $display functions for testing run time features like queues.
Run time features testing requires modification of scripts which should evaluate output of
run test.
At this moment are used two tags: :assert: and :re:. First one tests correctness of output. The second one expect specific output from tool e.g. full queue.

@tgorochowik
Copy link
Member

@hzeller the tests here implement the features that could be used for testing simulation.

I think there is no point delaying this PR as these tests will still work just fine for syntax checking, so should be included in the report as soon as possible.

We still have to decide if we want to go this way (and adjust the runners to eval the :assert: and :re: and then modify the remaining tests to also do that where applicable)

@tgorochowik tgorochowik merged commit 608ae0e into chipsalliance:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant