Add tests for chapter "Data types" #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
piotr-binkowski
force-pushed
the
chapter-6
branch
2 times, most recently
from
3ed7833
to
380293f
Compare
piotr-binkowski
changed the title
tgorochowik
reviewed
Sep 13, 2019
There was a problem hiding this comment.
@piotr-binkowski it seems that we have lots of test generators that are pretty much the same.
Maybe we could turn this into a single test generator and add config files which would contain the templates and all the inputs for them?
piotr-binkowski
changed the title
|
I think that this is a good idea to use a common generator script and config files specific to each case, I will create a separate PR for this change |
piotr-binkowski
force-pushed
the
chapter-6
branch
2 times, most recently
from
ba4f1ed
to
e5af1f3
Compare
piotr-binkowski
changed the title
piotr-binkowski
force-pushed
the
chapter-6
branch
5 times, most recently
from
434e5bd
to
151dc60
Compare
|
@piotr-binkowski the dependencies have been merged. Please rebase |
piotr-binkowski
force-pushed
the
chapter-6
branch
from
151dc60
to
a6704f0
Compare
Signed-off-by: Piotr Binkowski <pbinkowski@antmicro.com>
piotr-binkowski
force-pushed
the
chapter-6
branch
from
a6704f0
to
03d016e
Compare
tgorochowik
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends #99