Merge python3-rc2 branch into master #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed cases where join was used (previously unaddressed)
Will be reworking util commands within a separate pull request
Also depends upon merging in PR chipsec#524
still need to do necessary testing on all OS there are current issues with decompress
….Unicode() crashes on python3, use str instead
Fixed and pylint errors within the hal modules (mostly python3 syntax errors) Signed-off-by: user <brent.holtsclaw@intel.com>
added necessary functions within classes removed unnecessary code fixed up formatted string Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
mainly syntax and namespace errors Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
- Fix import errors - Fix python3 syntax changes Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
BrentHoltsclaw
requested review from
npmitche,
abazhaniuk,
cetola,
ErikBjorge,
frinzell,
hughsie,
iherna2,
johnloucaides,
mjauregu,
NicholasArmour and
tweksteen
NicholasArmour
approved these changes
Aug 14, 2019
frinzell
reviewed
Aug 15, 2019
Signed-off-by: BrentHoltsclaw <brent.holtsclaw@intel.com>
BrentHoltsclaw
force-pushed
the
merge_py3
branch
from
f039bb7
to
cc7b050
Compare
frinzell
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add python3 support to chipsec by merging in work from python3-rc2 branch