-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shimgen] no error written to standard error on error #142
Comments
Interesting. I would think log4net would do that properly. |
Can you expand on this a bit more? |
So the exit code should be non-zero. That's a start. The other side of this is that it should be writing to stderr for things that are logged as errors. |
In a C# application, I launch a new process that uses chocolatey to install a package and capture StandardOutput and StandardError. |
Dumb question, are you calling the shim? |
hrm. I might be. I'm calling cinst.exe |
This isn't new to choco 0.9.9 then :) |
What version of choco did you have in place before? |
0.9.8.33. |
the shims there would have been wrong as well though. |
let me double check this. I hope I haven't been wasting your time.... On Tue, Mar 3, 2015 at 2:13 PM, Rob Reynolds notifications@github.com
|
I wonder if there was something else in the path then... |
No it's good. The shims should properly output stderr to stderr. |
Previously, any errors written by a shim were logged to stdout. Not logging to stderr prevents applications that are watching for stderr from being able to capture errors. Capture and write errors to stderr. This is the same as https://github.com/chocolatey/shimgen/issues/14
new with 0.9.9, when you launch a process to install a chocolatey package and an error occurs (my example is 'elasticsearch not installed. The package was not found with the source(s) listed.'), it no longer writes anything to standard error.
It used to do this properly before 0.9.8. Is it on purpose that in 0.9.9 you need to parse standard output in order to detect an error?
The text was updated successfully, but these errors were encountered: