Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstallArguments option should work for 'choco install' #150

Closed
ovenhiker opened this issue Mar 6, 2015 · 0 comments
Closed

InstallArguments option should work for 'choco install' #150

ovenhiker opened this issue Mar 6, 2015 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug FeatureParity Priority_HIGH
Milestone
0.9.9.2

Comments

@ovenhiker
Copy link

It looks to me that there is a variable name mismatch in Install-ChocolateyInstallPackage.ps1 (dc704e9) which is preventing the use of the --installargs option to 'choco install'. Line 72 brings in a value from the environment named "chocolateyInstallArguments", but as far as I can see, line 163 of PowershellService.cs stores the installer arguements in the environment as "installerArguments" earlier on.

The installer arguments option was working in the released 0.9.8.
@ferventcoder ferventcoder added this to the 0.9.9.2 milestone Mar 6, 2015
@ferventcoder ferventcoder self-assigned this Mar 6, 2015
ferventcoder added a commit that referenced this issue Mar 7, 2015
@ferventcoder
(GH-150) Fix: InstallArguments is broken
8e9cc2e 
Previously, POSH Chocolatey was passing `chocolateyInstallArguments` as
the environment variable used containing the native installer arguments
passed in from the user. Choco was not passing this value as an
environment variable, so custom installer actions were failing.

Allow install arguments to work properly again.
ferventcoder added a commit that referenced this issue Mar 7, 2015
@ferventcoder
Merge branch 'stable'
9fd1a79 
* stable:
  (version) 0.9.9.2
  (doc) update changelog/nuspec
  (GH-142) shimgen - write errors to stderr
  (GH-150) Fix: InstallArguments is broken
@ferventcoder ferventcoder modified the milestones: 0.9.9.3, 0.9.9.2 Mar 26, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.9.2, 0.9.9.3 Mar 26, 2015
@ferventcoder ferventcoder mentioned this issue Mar 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug FeatureParity Priority_HIGH
Projects
None yet
Milestone
0.9.9.2
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @ovenhiker