(#2051) Make parameter description consistent #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an earlier commit, the default value of the WorkingDirectory parameter was changed to be $null, but the parameter description wasn't updated.
ferventcoder
reviewed
Mar 1, 2021
| `Get-Location`. If current location is a UNC path, uses | ||
| `$env:TEMP` for default as of 0.10.14. | ||
| `$null`. If current location is a UNC path, uses `$env:TEMP` for default | ||
| as of 0.10.14. |
There was a problem hiding this comment.
If null is passed in, it will set it to Get-Location - that note needs to be addressed here me thinks?
ferventcoder
requested changes
Mar 1, 2021
ferventcoder
referenced
this pull request
Mar 10, 2021
The previous commit 9e2e49a to address UNC paths broke the ability to provide a working directory to the Start-ChocolateyProcessAsAdmin helper function. The test `$workingDirectory.ProviderPath -eq $null` always evaluates to true because the String type does not have the member ProviderPath. The fix is to obtain the location object only when no path is provided to the helper and to verify its validity before use, possibly falling back to the cache location, similar to how it was implemented for Get-ChocolateyUnzip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an earlier commit, the default value of the WorkingDirectory
parameter was changed to be $null, but the parameter description wasn't
updated.