-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme hook #120
Add theme hook #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing useTheme will return default theme unless overwritten by some ThemeContext higher up in the hierachy. Therefore we should always use useTheme to get our theme.
Unless we explicitly want the default theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the implementation. One thing we might want to consider is changing the naming scheme for the font-size from 16, 24, 36, to small, standard, title, just so that if we were to change the size itself the naming convention won't need changing. But I also think this naming may be confusing to use so I'll leave it up to you if want to make this small change. Approved either way.
flexibility in the future. Removed caret light icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed I have missed some icons in the style guide, so after discussing with Richard we made some changes together to include the new icons and deleted some no-longer-used icons. And we made some changes to naming scheme of the variables to be more flexible if we were to change it in the future. Please have a look at richard/theme-hook
is not used correctly here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Adds: