Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put card.update in CardDetail render into a useEffect #144

Merged
merged 1 commit into from
Oct 7, 2021
Merged

put card.update in CardDetail render into a useEffect #144

merged 1 commit into from
Oct 7, 2021

Conversation

chomosuke
Copy link
Owner

so that react don't complain about setstate called in render

@chomosuke chomosuke added the bug Something isn't working label Oct 7, 2021
@chomosuke chomosuke self-assigned this Oct 7, 2021
@chomosuke chomosuke changed the title put card.update into useEffect put card.update in CardDetail render into a useEffect Oct 7, 2021
@chomosuke chomosuke merged commit b74f111 into master Oct 7, 2021
@chomosuke chomosuke deleted the richard/no-update-in-cardDetail-render branch October 7, 2021 09:52
@waltervan00 waltervan00 added this to the Sprint 2 milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangzhel shangzhel shangzhel approved these changes

Assignees

@chomosuke chomosuke

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.
3 participants
@chomosuke @shangzhel @waltervan00