Richard/issue69 #70
Merged
Richard/issue69 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chomosuke
force-pushed
the
richard/issue69
branch
from
0c4b982
to
e102d53
Compare
shangzhel
requested changes
Sep 9, 2021
server/src/server.ts
Outdated
| @@ -47,6 +47,8 @@ const errorHandler: ErrorRequestHandler = (err, _req, res, _next) => { | |||
| } | |||
|
|
|||
| res.sendStatus(500); | |||
|
|
|||
| console.log(err.stack); | |||
There was a problem hiding this comment.
Use console.error to write out the error to stderr. Also write out all the information about the error, not just the stack.
Suggested change
| console.log(err.stack); | |
| console.error(err); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printed error and allowed empty string on mongoose