Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added home view logic, including showing, expanding, and collapsing of card detail section #74

Merged
merged 31 commits into from
Sep 10, 2021
Merged

Added home view logic, including showing, expanding, and collapsing of card detail section #74

merged 31 commits into from
Sep 10, 2021

Conversation

oldbugo
Copy link
Collaborator

@oldbugo oldbugo commented Sep 10, 2021 •
edited by chomosuke
Loading

closes #14
closes #6

This branch now contain everything for sprint 1

oldbugo and others added 21 commits September 8, 2021 21:23
@oldbugo
added in basic card grid view logic
d544e0e
@chomosuke
CardDetail fields skeleton, Mandatory fields done
c758f8f
@chomosuke
action buttons
b939851
@chomosuke
scroll card detail
bbf4803
@chomosuke
not printing empty mandatory field
17a6e23
@chomosuke
add and delete extra field, ensure existence of a note field
ca23286
@chomosuke
card note field
e646169
@chomosuke
CardImageField not building
bc524d2
Lift Home context into HomeContext.ts.
9817b07
Ensure home context is not null.
40be6d0
@chomosuke
CardImageField
d3d6f2e
@chomosuke
Merge remote-tracking branch 'origin/master' into richard/cardDetailView
11885cb
@oldbugo
added card detail expansion logic, and card
2cceecd 
filter logic
@chomosuke
cardImageField
3e207ee
@chomosuke
only accepting image file
6f70c61
@chomosuke
close button and new card cancel fix
539c86f
Implement Card component.
f509d05
@chomosuke
loading text
ff40a42
@chomosuke
delete button
59fe708
@oldbugo
fix home card detail expanding view using
565d177 
GridTemplate instead of growing stack
@oldbugo
added scrolling of card section in home
f9989d5
@oldbugo oldbugo added the enhancement New feature or request label Sep 10, 2021
@oldbugo oldbugo added this to the Sprint 1 milestone Sep 10, 2021
chomosuke
chomosuke requested changes Sep 10, 2021
View reviewed changes
web/src/views/Home.tsx Outdated Show resolved Hide resolved
chomosuke
chomosuke requested changes Sep 10, 2021
View reviewed changes
Copy link
Owner

@chomosuke chomosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls merge my branches, I think there's interfaces changes that we need to do

specifically, cardDetails needs to know if it's expanded or not.

@oldbugo oldbugo mentioned this pull request Sep 10, 2021
Closed
@chomosuke chomosuke self-assigned this Sep 10, 2021
chomosuke
chomosuke approved these changes Sep 10, 2021
View reviewed changes
Copy link
Owner

@chomosuke chomosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shangzhel
shangzhel approved these changes Sep 10, 2021
View reviewed changes
Copy link
Collaborator

@shangzhel shangzhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@shangzhel shangzhel merged commit 7a7cfa7 into master Sep 10, 2021
@shangzhel shangzhel deleted the yujian/homeView branch September 10, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangzhel shangzhel shangzhel approved these changes

@chomosuke chomosuke chomosuke approved these changes

@waltervan00 waltervan00 Awaiting requested review from waltervan00

Assignees

@chomosuke chomosuke

@shangzhel shangzhel

@oldbugo oldbugo

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

Implement home screen view Add card detail component
3 participants
@oldbugo @chomosuke @shangzhel