modified API to imageHash instead of hasImage #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you need to change Card.md as well? |
|
I believe I have done that? What change specifically do you refer to |
|
Oh apologies. |
shangzhel
requested changes
Sep 16, 2021
docs/api/Card.ts
Outdated
| @@ -9,7 +9,7 @@ export interface Card { | |||
| email: string; | |||
| jobTitle: string; | |||
| company: string; | |||
| hasImage: boolean; | |||
| imageHash?: string; | |||
There was a problem hiding this comment.
Use the Hashed type.
import { Hashed } from './Hashed';
Suggested change
| imageHash?: string; | |
| imageHash?: Hashed; |
There was a problem hiding this comment.
I thought Hashed specifically refers to password hash. Where as imageHash is just a fairly unique string associated with the image?
|
You mean image.md? image.md does not need to update because that endpoint actually does not get modified, except cache-control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's only 3 places to change?