check if a hash is a valid selector [fixes uncaught error] #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greeting 👋👋
this PR fixes an issue I had pertaining to the function
updateLocation
Some hashes may not be valid selector for
document.querySelector
(for instance, if an email such as choo@example.com is used as a hash) and will actually crash an app due the error not being handled. I would get this error for example:I think ideally it would be best to make a separate module such as
isValidSelector
and use that here, but thistry/catch
works for now.