[major] choo v4 #352
Merged
[major] choo v4 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [ ] don't break hashing - [ ] allow not changing the url fixup! move fns around fixup! add search string
* router: update to latest sheet-router * tests: fix for latest version * tests: fix SSR * tests: fix history
* s/data, state/state, data/ * feat(api): swap arguments
Lol can't use forEach
| ${pathname(state, prev, send)} | ||
| ${nav(state, prev, send)} | ||
| <section class="fl mt4 w-80 db"> | ||
| ${emailList(state, prev, send)} | ||
| </section> | ||
| </main> | ||
| ` | ||
|
|
||
| function goHome () { | ||
| send('location:set', { pathname: '/' }) |
There was a problem hiding this comment.
is this supposed to be {href: '/'} ?
There was a problem hiding this comment.
This does require a bit of clarification. A quick demo shows that { href: '/' } changes window.location and reroutes the way I expect it should. However, the documentation was updated to use { pathname: '/'} which doesn't update the window.location, nor does it re-route correctly (though it does appear to change the state).
|
Yeah it should probably href as that updates the whole url - PR welcome for
docs fixes hah 😅
…On Mon, Dec 12, 2016 at 12:55 AM Eric Buckthal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/mailbox/views/mailbox.js
<#352>:
> ${pathname(state, prev, send)}
${nav(state, prev, send)}
<section class="fl mt4 w-80 db">
${emailList(state, prev, send)}
</section>
</main>
`
+
+ function goHome () {
+ send('location:set', { pathname: '/' })
This does require a bit of clarification. A quick demo shows that { href:
'/' } changes window.location and reroutes the way I expect it should.
However, the documentation was updated to use { pathname: '/'} which
doesn't update the window.location, nor does it re-route correctly
(though it does appear to change the state).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#352>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWlejx3CNSq8hGeZotpOeq_1yv-UuUEks5rHI1jgaJpZM4LJ_nO>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update choo to version 4 ✨ - changes are included in
CHANGELOG.md. I'd copy and paste it here, but my clipboard has crashed and I'm live streaming so lol can't reboot computer