This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Add PERMISSIONS_ENABLED setting #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruth
changed the title
|
|
||
| published = get_objects_for_user(user, perm, published) | ||
| elif settings.PERMISSIONS_ENABLED is True: | ||
| raise ImproperlyConfigured('django-guardian must installed to ' |
There was a problem hiding this comment.
must installed to => must be installed to
|
Looks good other than the 2 config error messages. Will merge after those are updated. |
This fixes an ambiguity when applying the permissions if a user is passed to the published() manager method for DataField and DataConcept. Fix #252 Signed-off-by: Byron Ruth <b@devel.io>
|
Updated. |
naegelyd
added a commit
that referenced
this pull request
Oct 19, 2014
Add PERMISSIONS_ENABLED setting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an ambiguity when applying the permissions if a user is
passed to the published() manager method for DataField and DataConcept.
Fix #252
Signed-off-by: Byron Ruth b@devel.io