This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Fixes for python3 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
commented
Nov 21, 2018
| @@ -572,7 +571,7 @@ def _find_relations(self, node, depth=0): | |||
| # NOTE: the many-to-many relations are evaluated first to prevent | |||
| # 'through' models being bound as a ForeignKey relationship. | |||
| fields = sorted(model._meta.get_fields(), reverse=True, | |||
| key=lambda f: f.many_to_many) | |||
| key=lambda f: bool(f.many_to_many)) | |||
There was a problem hiding this comment.
This will no longer sort None and False separately, but I believe that it maintains correct behavior.
Signed-off-by: Dan Davison <dandavison7@gmail.com>
Signed-off-by: Dan Davison <dandavison7@gmail.com>
|
These changes LGTM. Will defer to @bruth to merge. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the test suite to test Python 3.7 in addition to 2.7, and makes the few changes necessary to get the tests to pass on both (plus a
__str__/__unicode__magic method change which the tests don't address).