Skip to content

Fixed deprecated field.rel access #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pmaddi
Copy link

@pmaddi pmaddi commented Jan 18, 2017

This handles the RemovedInDjango20Warning in the field.rel.to access.

@coveralls
Copy link

coveralls commented Jan 18, 2017

Coverage Status

Coverage decreased (-0.3%) to 92.655% when pulling c54d623 on pmaddi:master into bce1d59 on chrisdev:master.

@chrisdev
Copy link
Owner

@pmaddi thanks for the PR but its failing in Python 2.6. I'm reluctant to remove support for 2.6 at this moment

@pmaddi
Copy link
Author

pmaddi commented Jan 19, 2017

@chrisdev I absolutely agree. Would you happen to have any insight as to why the tests are failing on Python 2.6?

I'm seeing that the pandas import is raising the error

  File "/home/travis/build/chrisdev/django-pandas/django_pandas/io.py", line 1, in <module>

    import pandas as pd

  File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/pandas/__init__.py", line 22, in <module>

    from pandas.compat.numpy import *

  File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/pandas/compat/__init__.py", line 334, in <module>

    from collections import OrderedDict, Counter

ImportError: cannot import name OrderedDict

However, I don't understand how this change would effect anything about this library's pandas compatibility.

@chrisdev
Copy link
Owner

@pmaddi I think the OrderedDict referenced in Pandas is not in Python 2.6.
The problem is with the version of Pandas that setup.py chooses to install since we are not pinning the exact version of Pandas to install ( >= instead of == ). So in the setup.py we have pandas >= 0.14.1 or in travis.yml pandas >= 12.0 I'm assuming that instead of 0.14.1 (which is was doing before for 2.6) it's now installing a more recent version of Pandas.
The best solution is to ensure that for the Python 2.6 travis, will install a Pandas version that does not require OrderedDict. I think this could be 0.14.1 but I don't want to put my head on a block about this

@pmaddi
Copy link
Author

pmaddi commented Jan 19, 2017

@chrisdev Ah, I see. I'll go ahead and close this then!

@pmaddi pmaddi closed this Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants