Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof P51-P53 pages 956-965, continuation of issue #617 #833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serialhex
Copy link
Contributor

This is for pages 956-965. It does not overlap my previous PRs and can be (or should be able to be) merged separately.

Sorry it took me a little longer to get to this, work's been busy. The rest will be done as soon as I can.

@serialhex
Copy link
Contributor Author

I forgot to mention. On line 1616/1623 there is a bit of an issue. The easiest way to find it actually is to grep for # Page 964 as that is the actual problem.

If you look at the bottom of page 963, and the top of 964, there is an ASCII diagram (probably not ASCII, but text, whatever). The # Page 964 page break text that is added as a comment for each page precedes the diagram, but should actually be after the first 2 lines of the diagram.

While this is technically incorrect, I left it before the diagram to make the diagram easier to read. If you want me to put it where it ought to be that isn't a big deal and easily done. Though, IMHO, the # Page 964 line isn't in the original code so putting it "where it should be" would be removing it completely. 😜 I understand why they are placed there, so it's fine, and I think it should be before the diagram, so that is why I left it there.

Let me know if you want me to move it. Otherwise you can ignore this message.

@github-actions github-actions bot added the Type: Proof Comanche55 and Luminary99 files label Oct 21, 2021
@wopian wopian added this to the Luminary099 milestone Oct 22, 2021
@wopian wopian self-assigned this Oct 22, 2021
@wopian wopian self-requested a review October 22, 2021 13:22
@wopian
Copy link
Collaborator

wopian commented Oct 22, 2021

While this is technically incorrect, I left it before the diagram to make the diagram easier to read. If you want me to put it where it ought to be that isn't a big deal and easily done.

Looks like it would be fine staying before the diagram, just for the sake of readability alone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants