Skip to content

add validation to configureCurl method #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2024
Merged

add validation to configureCurl method #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c637d00
add validation for configureCurl method
abmarkenwerk Aug 2, 2024
1c3a54b
Merge branch 'chroma-x:master' into master
andriusbaliutis Aug 2, 2024
f8cc824
update readme.md
abmarkenwerk Aug 2, 2024
fd96892
Merge remote-tracking branch 'origin/master'
abmarkenwerk Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ A JSON HTTP client library. This project also is the reference implementation fo
```{json}
{
"require": {
"chroma-x/json-http-client": "~3.0"
"chroma-x/json-http-client": "~4.0"
}
}
```
Expand Down
6 changes: 5 additions & 1 deletion src/Request/Message/Body/JsonBody.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,12 @@ public function __construct(array $bodyData)
$this->bodyData = $bodyData;
}

public function configureCurl(\CurlHandle $curl): self
public function configureCurl(\CurlHandle|false $curl): self
{
if ($curl === false) {
throw new \TypeError('cURL is not a valid CurlHandle class.');
}

$jsonBody = json_encode($this->bodyData);
if ($jsonBody === false) {
throw new HttpRequestMessageException('JSON body data not serializable.');
Expand Down