Write to log file and add --upload-metadata to publish metadata files
#836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
requested review from
tmeasday,
JonathanKolnik,
tevanoff and
thafryer
and removed request for
tmeasday and
JonathanKolnik
ghengeveld
changed the title
--upload-metadata to publish certain metadata files when the build finishes--upload-metadata to publish certain metadata files
ghengeveld
changed the title
--upload-metadata to publish certain metadata files--upload-metadata to publish metadata files
ghengeveld
changed the title
--upload-metadata to publish metadata files--upload-metadata to publish metadata files
tevanoff
reviewed
Oct 12, 2023
|
@tevanoff I opened a PR for the CDN to not allow public (non-member) access to these files. |
|
@ghengeveld perhaps change the PR description as this could unduly worry someone who reads this PR. |
ghengeveld
added
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AP-3531, AP-2517
First of all, this updates our logging to write the CLI logs to a
chromatic.logfile besides printing to the terminal. The log file format is akin to what the logs look like in CI.Secondly, this adds an option to upload a set of "metadata" files, which will be available as part of the published Storybook in the
.chromaticdirectory. A directory index is provided:📦 Published PR as canary version:
7.5.0--canary.836.6619467092.0✨ Test out this PR locally via:
npm install chromatic@7.5.0--canary.836.6619467092.0 # or yarn add chromatic@7.5.0--canary.836.6619467092.0