Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Design Systems for Developers guide #137

Closed
domyen opened this issue Sep 20, 2019 · 6 comments
Closed

Review Design Systems for Developers guide #137

domyen opened this issue Sep 20, 2019 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@domyen
Copy link
Member

domyen commented Sep 20, 2019

@tmeasday and I are creating a new Storybook guide! 🎉 It'll be launched with the website refresh that @kylesuss is working on here.

Overview
“Design systems for developers” is a free 9-chapter guide that teaches professional developers about the design system infrastructure and production workflows used by the smartest frontend teams. It focuses on Storybook and includes real code + example repositories.

Feedback areas
General feedback is definitely appreciated. Here are some specific areas that could use extra attention:

  • Logical consistency: Does it make sense?
  • Syntax and grammar: Does it conform to the standards of the English language?
  • Tone and flow: Is it enjoyable to read?
  • Code samples: Is code sensible and skim-able while reading?

👉Read the preview here👈

We'd love early feedback from contributors 🙏
@jonniebigodes @icarlossz @alterx @luchux @danielduan @chinanf-boy

@domyen domyen added the help wanted Extra attention is needed label Sep 20, 2019
@jonniebigodes
Copy link
Collaborator

@domyen i've been following the awesome work @kylesuss been doing in the preview and it's looking awesome. If you don't mind i'll go over it tonight and during the weekend and i'll report back. Sounds good?

@domyen
Copy link
Member Author

domyen commented Sep 20, 2019 via email

@jonniebigodes
Copy link
Collaborator

i've gone through it and left in some comments. But asides from that, nice effort on your part on creating such a really well written and essential piece of documentation, that's also easy to follow.

Can't wait to see this published and available.

@domyen and @tmeasday i would like to thank you both for your effort in putting this together.

@danielduan
Copy link
Contributor

Looks pretty good! I put some thoughts there as well.

@domyen
Copy link
Member Author

domyen commented Oct 2, 2019

This is now published. Thanks folks 🙇

@domyen domyen closed this as completed Oct 2, 2019
@jonniebigodes
Copy link
Collaborator

@domyen no need to thank, glad that i was able to provide some insights and contribute to it. Going to check it out shortly and start working on the translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants