Remove '$' in command line code snippets #210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since code snippets have a copy function, when copying the command, the '$' was included. When pasting on the command line, and error occurs: ```sh zsh: command not found: $ ``` When removing the '$', the code snippet commands can be pasted and run without having to delete the '$' character.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aarongable
pushed a commit
that referenced
this pull request
Jan 19, 2024
This is a commit that patches a crash that was caused by referencing `WindowResizer` before confirming its existence. `in_gesture_drag_` should be marked `false` in case `ToplevelWindowEventHandler` fails to create `WindowResizer` in order for it to be in sync with the state. We also added a check for the existence for `WindowResizer` before referencing it for extra safety as well. (cherry picked from commit 3f85e3f) Bug: 1497046, b/307846601 Change-Id: I241653822526688fe75c333401a7a21c13ca3980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4994950 Reviewed-by: Kazuki Takise <takise@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Auto-Submit: Masa Fujita <massan@google.com> Commit-Queue: Masa Fujita <massan@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1218605} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4997135 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Qijing Yao <yaoqq@google.com> Cr-Commit-Position: refs/branch-heads/6099@{#210} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 19, 2024
Roll Chrome Mac PGO profile from chrome-mac-6167-1702265164-e24829a725fb80504316b25c9a23f161ba2bc3f2.profdata to chrome-mac-6167-1702293153-b4e90d4c1ecf1e6823186de92d891a78b01de4f6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I788a2ce8fcfab14a0d3deb79f80b8f308cdcee29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5110400 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#210} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 19, 2024
PR_PAC_GET_ENABLED_KEYS returns which pointer authentication crypto keys are active. Chromium generally doesn't need to know, but debuggerd on Android reports them to assist crash diagnosis. (cherry picked from commit 2abdd24) Bug: 1474248 Change-Id: I3e2be1ae94392eccf7580d36b11642e79dbd01a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4842874 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1194799} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4857329 Auto-Submit: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5993@{#210} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
aarongable
pushed a commit
that referenced
this pull request
Jan 26, 2024
Change-Id: I6afb9bf728fa704e9b29d8d4bfe652925fe4fe06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4502306 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{#210} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
aarongable
pushed a commit
that referenced
this pull request
Jan 29, 2024
Roll Chrome Linux PGO profile from chrome-linux-6261-1706478259-e452ab9ba4ed0eaaacb026d6ed54e22ad455b6c6.profdata to chrome-linux-6261-1706498537-cb36b4d74a7f2caea1e401e4b215893c09e31250.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifce81c6b0918ea34a5cf3e1198a13681201e4333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5244288 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#210} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
NaaeemMalik
pushed a commit
to AsilHQ/Asil-Chromium
that referenced
this pull request
Feb 8, 2024
Verified that Firefox also passes this test. Bug: 1489495 (cherry picked from commit 1cb309a) Change-Id: I3333dec1d8c0aba82cf824f8bb464287177391bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920161 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1206706} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4923371 Cr-Commit-Position: refs/branch-heads/6045@{chromium#210} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Feb 12, 2024
After https://crrev.com/c/4177472, -firstRectForCharacterRange starts to crash because one of its argument is out of the range of gfx::Range. Turn that argument into an invalid range to suppress the crash. (cherry picked from commit 48e8d1b) Bug: 1409669 Change-Id: I70f2b215d8194f4bd1c952e0f09ee464699893c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209470 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1099448} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4225751 Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{chromium#210} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable
pushed a commit
that referenced
this pull request
Feb 27, 2024
Pass the value from interest group config and auction config mojom to worklet processes as feature integration. Github: WICG/turtledove#767 (cherry picked from https://chromium-review.googlesource.com/c/chromium/src/+/5318311 commit 8333e7c) (cherry picked from commit 8333e7c) Bug: 324416012 Change-Id: I7208a54b1c50dde51e270add2b30fb7a92de61fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318311 Reviewed-by: mmenke <mmenke@chromium.org> Commit-Queue: Tianyang Xu <xtlsheep@google.com> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1264762} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5327686 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#210} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson
pushed a commit
to chromium-cheri/chromium
that referenced
this pull request
Mar 15, 2024
Roll Chrome Win32 PGO profile from chrome-win32-5790-1685553847-f222aab09804eb16279a1be58f9dd310be3898e7.profdata to chrome-win32-5790-1685572025-b51e8f8c7ed20df8af69be789c4f16b3724fa33c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m115.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7aedb1054b07ed236e48e1df3689ca8294fcb760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577812 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#210} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
This is a reland of commit 1562361 which was reverted here: crrev.com/c/4769364 Original change's description: > [Auto-disable Accessibility] Add histograms for feature usage > > This CL continues the work of the Auto-disable accessibility feature > in preparation of enabling the feature for A/B testing. > > With this CL we add histograms to track usage of the feature. We will > track how often we enable/disable the feature, and how long the given > instance was in the current state before changing (e.g. how long was > accessibility enabled before being auto-disabled, or, how long was > accessibility disabled before re-enabling). We also separate these > into initial and successive categories to separate the first call for > each instance from any later calls. > > AX-Relnotes: N/A > Bug: 1430202, b/265493191 > Change-Id: Ibc42854105af4b486db39c6066bb468ca6f8f57f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4738305 > Reviewed-by: Amanda Lin Dietz <aldietz@google.com> > Reviewed-by: Evan Liu <evliu@google.com> > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Cr-Commit-Position: refs/heads/main@{#1181705} (cherry picked from commit ca5fddf) Bug: 1430202, b/265493191 Change-Id: Ic3581bdb9e3178995c77e82dd57e596727af2a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4770714 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by: Amanda Lin Dietz <aldietz@google.com> Reviewed-by: Evan Liu <evliu@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1182811} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4784188 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/branch-heads/5938@{chromium#210} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Mar 25, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6367-1711339532-b487a87910b1f5267746247dee4c711a6745cecb-86072a8a4ae2686ab42b026a94b7aeeb8ed1b235.profdata to chrome-win64-6367-1711366904-f381357a5bc11f26d62b0c884e827fe01961c9c5-c055d4ed29a25eb8dd7d7cb23be90527690440b5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9252572058727b2f68bf84ac0e77a2c8e1365d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391660 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#210} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 22, 2024
(Merge to release branch M125) This CL adds a pref within the local state (client level) prefs store to be shared across profiles. Details: https://docs.google.com/document/d/1mlyJ79UZOhoU2HecfcJIqkoMaGuYrYYtCKr2OnlQyDo/edit?usp=sharing - go/sgac (cherry picked from commit 73b97ef) bug: b:332423626 Change-Id: I44cc052fb3d6b81b0ddec3f6a995be3032647fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5445323 Reviewed-by: Matt Mueller <mattm@chromium.org> Reviewed-by: Anton Maliev <amaliev@chromium.org> Commit-Queue: Jonathan Njeunje <njeunje@chromium.org> Reviewed-by: Dominic Battre <battre@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1288684} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466040 Auto-Submit: Jonathan Njeunje <njeunje@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#210} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 18, 2024
Automatic update for 2024-05-18 UTC Change-Id: I8ec6874582ebcb0133f5cee6ac4eb9334cf63a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5549592 Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#210} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
aarongable
pushed a commit
that referenced
this pull request
Jun 16, 2024
Roll Chrome Linux PGO profile from chrome-linux-6533-1718452507-7e386a19c01b4cdebb63928e21ea11f64d24ae18-9bab27449c02be3c398283d958ecbbf18fa55445.profdata to chrome-linux-6533-1718469758-06938d7af037b6e21566588b1a5cdc9bd9344834-9c2fa69e5a5eb89cdd3d419b65e9b311c8c88d34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m127.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I547c392684f087d8d9e30818fb9d26c94f568843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5634822 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6533@{#210} Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}
aarongable
pushed a commit
that referenced
this pull request
Jul 28, 2024
Roll Chrome Win32 PGO profile from chrome-win32-6613-1722077087-7fe6f061b76f0239a2f507f605daa787a512e89d-8409b8d092cd8c77a9831941a7e5e615ab9469ab.profdata to chrome-win32-6613-1722102246-42edaa74a56e02ee35e91626b151961e19dfc457-4574ebde3f59d267d98bdb4da5cf34e7b8e1080b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m128.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifb4328a8ad8d30e9d175c150975fa50a3bb93e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5745227 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6613@{#210} Cr-Branched-From: 03c1799-refs/heads/main@{#1331488}
kaidokert
added a commit
to kaidokert-personal-org/chrobalt_sandbox
that referenced
this pull request
Aug 20, 2024
aarongable
pushed a commit
that referenced
this pull request
Aug 24, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6668-1724419935-5d71f002e439285437560d47dcb8e20ddf1c17a3-2102a152eda635b703eb4d7b0acf592a9c8e081b.profdata to chrome-mac-arm-6668-1724427335-07eb3d841d337356605303e855d8b9854e897129-22718b9af37939ab92ddf8d6bd06b3491204d18a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieb44469ff04ebb7d871bbd5469494c1ff41ecdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809048 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6668@{#210} Cr-Branched-From: 05bc664-refs/heads/main@{#1343869}
aarongable
pushed a commit
that referenced
this pull request
Sep 21, 2024
This CL adds new metrics to track user interactions with Safety Check Notifications. It logs events for when notifications are sent, triggered, interacted with by the user, and dismissed. These metrics will help us understand the effectiveness of Safety Check Notifications and identify areas for improvement. (cherry picked from commit 0043a02) Change-Id: Iaf17b981d1f194466fa02e49031cf182f7149efe Fixed: 362481419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5868179 Reviewed-by: Scott Yoder <scottyoder@google.com> Reviewed-by: Ali Juma <ajuma@chromium.org> Auto-Submit: Benjamin Williams <bwwilliams@google.com> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1357188} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5877775 Commit-Queue: Benjamin Williams <bwwilliams@google.com> Cr-Commit-Position: refs/branch-heads/6723@{#210} Cr-Branched-From: 985f296-refs/heads/main@{#1356013}
aarongable
pushed a commit
that referenced
this pull request
Oct 19, 2024
Roll Chrome Mac PGO profile from chrome-mac-6778-1729208908-1e13cb4bd5653e9102fa10fda6b6c47c464f6cdd-9e2623200c983f27fce847115fbe58ae2250ab38.profdata to chrome-mac-6778-1729229942-86aeb820a96237161aacba9729a0a28eb930c336-f1bedb3593ce80558a9528b61007b9e79569be13.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8dd7059e140da2d9c12e833b831bb62169a1af04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5942070 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#210} Cr-Branched-From: b21671c-refs/heads/main@{#1368529}
aarongable
pushed a commit
that referenced
this pull request
Nov 16, 2024
(cherry picked from commit ab5aa0a) Bug: 378554652,378908352 Change-Id: I1221f67d3eba5108071bca87e334867cfd61dcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6012719 Reviewed-by: Tomasz Wiszkowski <ender@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Brandon Wylie <wylieb@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1381891} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024390 Auto-Submit: Brandon Wylie <wylieb@google.com> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/branch-heads/6834@{#210} Cr-Branched-From: 47a3549-refs/heads/main@{#1381561}
aarongable
pushed a commit
that referenced
this pull request
Jan 14, 2025
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6943-1736877286-2daa487bd73c435f9856325e468ebc99e144fce3-dc902240cc84f5a1a432c52550a81bbcada0568c.profdata to chrome-mac-arm-6943-1736884750-2fbb542f742cb6f5109a05356837b5c81e4f32bf-28808eeaf1509b31b4fed39e97e2f8fb95d7e062.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I08f12d9a1742717ab6dc6f0d79e6435a856a7968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6175847 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6943@{#210} Cr-Branched-From: 72dd0b3-refs/heads/main@{#1402768}
aarongable
pushed a commit
that referenced
this pull request
Feb 8, 2025
… to start after adding the tab. The issue is that the selection list can be the same if calculated before and after despite the active and selected tabs changing. By incrementing the selection model and not changing the actual tabs selected / active and the calculating selection change, this issue is avoided. (cherry picked from commit b47de9e) Bug: 394381780 Fixed: 395121277 Change-Id: Iedc16b7bc69a905bd327abbd98b8ed942c793340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6236188 Commit-Queue: Shibalik Mohapatra <shibalik@chromium.org> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1416476} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244224 Cr-Commit-Position: refs/branch-heads/6998@{#210} Cr-Branched-From: de9c6fa-refs/heads/main@{#1415337}
aarongable
pushed a commit
that referenced
this pull request
Mar 7, 2025
Roll Chrome Android ARM64 PGO profile from chrome-android64-7049-1741350182-05ea396db656be124d47a4c02d2b329021a3f6d7-6d8c870915ca54b6e7260cbdfc43f137b9b6ad88.profdata to chrome-android64-7049-1741355085-cf2a44a0d60ac6bb7c291806bd4565aee06fd3b8-3decd030e55e1c2450b86ccdc98e720ed8e07b55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: Iee02d50778547d3ed119e52ca1290a9da7cdc9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335988 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7049@{#210} Cr-Branched-From: 2dab784-refs/heads/main@{#1427262}
aarongable
pushed a commit
that referenced
this pull request
Apr 5, 2025
Roll Chrome Android ARM64 PGO profile from chrome-android64-7103-1743794693-483d446be353e034ea13b2fd0068e3c10da19ab7-1a5decb83f692115d30f978255bc443ca92aeea2.profdata to chrome-android64-7103-1743797438-b7ce1a8bc1523133a631ffe0c16ae6064c604c07-aa64db6c7a47e0ef8a707786ed108c9c05cf7f40.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: Ie3ac520926cab54f1c50fe1cbbb44d83c5706e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435083 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7103@{#210} Cr-Branched-From: e09430c-refs/heads/main@{#1440670}
miaobin
pushed a commit
to miaobin/chromium
that referenced
this pull request
Apr 8, 2025
Fix chromium#60 Also fix the rank range of some operators.
huningxin
pushed a commit
to huningxin/chromium-src
that referenced
this pull request
Apr 11, 2025
Fix otcshare#60 Also fix the rank range of some operators.
aarongable
pushed a commit
that referenced
this pull request
May 3, 2025
Roll Chrome Win32 PGO profile from chrome-win32-7151-1746163893-f0efee13367e9f4b0a59fffad2798aa26e0047ab-690966f6694c5893718d38096942f6a41a44fa59.profdata to chrome-win32-7151-1746208516-26ddb3fd684d80dd68a379eb58b275977d92fd46-e71e2d9187fa80b5f3eae0c7e426cebfee6ce87e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m137.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Merge-Approval-Bypass: Chrome autoroller Change-Id: I78f88e21da32468fb14f175fbf1de3395b293715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6509439 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7151@{#210} Cr-Branched-From: 8e0d32e-refs/heads/main@{#1453031}
aarongable
pushed a commit
that referenced
this pull request
May 31, 2025
Original change's description: > Headless now handles pre-31 and broadcasts. > > When in headless mode, we try to keep all tab models loaded at all > times. Conceptually this is a no-op for pre-31, since they already keep > all tab models in memory, and collapse/merge on shut down of one. > > However, the headless code also tries to unmap orphaned tab groups and > is responsible for broadcasting session restore for sync. These two > scenarios need to be handled even when getInstanceInfo() returns > nothing. > > Bug: 419353855 > Change-Id: I6d819654f49c226c657a8b0ef1b74f92b72e0357 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6576546 > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1466075} Bug: 421422341,419353855 Change-Id: I6d819654f49c226c657a8b0ef1b74f92b72e0357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6604722 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7204@{#210} Cr-Branched-From: d5de512-refs/heads/main@{#1465706}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since code snippets in Github have a "copy to clipboard" button, when copying the command, the '$' was being included. Then, when pasting on the command line, this error occurred:
This PR removes the '$' in all of the command code snippets, so can be pasted and run without having to delete the '$' character.