Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing glimpse of 'Green' when clicking while in chrome dev tools emulator mode #95

Closed
wants to merge 4 commits into from

Conversation

andypaicu
Copy link
Collaborator

Issue is caused by emulator putting a blue highlight box around the button. Changing the cursor to default fixes this and there isn't much lost since the button already highlight on hover.

@andypaicu
Copy link
Collaborator Author

This is the original bug crbug.com/1163837

@lgarron
Copy link
Collaborator

lgarron commented Apr 13, 2022

Hmm, the pointer pointer is an accessibility cue.

Would it make more sense to prevent the active state from using a highlight color, or removing the yellow state?

@lgarron
Copy link
Collaborator

lgarron commented Apr 13, 2022

Also, this kind of combined highlighting happens on other sites — I assume the main concern here is that green normally means success, and having a flash of green is therefore confusing?

@andypaicu
Copy link
Collaborator Author

I didn't know the pointer had accessibility implications. In that case this approach isn't reasonable.

Yes, that is the confusion. It makes it seem that the button indicates a quick "granted" state because that's how this site indicates the success operation.

I don't know how to prevent the highlighting color, that one comes from the chrome dev tools mobile device "simulator".
Removing the yellow background makes more sense to me but I'm wondering if maybe we could change it to a light blue instead? WDYT?

@engedy
Copy link
Collaborator

engedy commented Apr 28, 2022

Happy to give this a try.

@andypaicu
Copy link
Collaborator Author

Closing to clean up commit range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants