Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cefclient: Windows: Japanese IME popup is placed incorrectly with OSR #3313

Open
magreenblatt opened this issue Apr 15, 2022 · 14 comments
Open
Labels
bug Bug report cefclient Related to the cefclient sample app help wanted Issue resolution will likely require community contributions osr Related to off-screen rendering SampleApps Related to sample apps windows Windows platform

Comments

@magreenblatt
Copy link
Collaborator

Original report by Andrew Smith (Bitbucket: Andrew Smith).


The Japanese IME popup is displayed on the bottom right side of the screen when the composition starts.


This only happens when using the offscreen rendering.

Steps:

  • Run cefclient:

cefclient.exe --multi-threaded-message-loop --no-sandbox --off-screen-rendering-enabled --enable-gpu

  • Switch to Hiragana using Japanese IME

  • Type ‘a'

The results are as shown in the image above. It seems like the issue is that the browser is not provided the character bounds until after the composition has started and so the calls to position the ime candidate window are not made until after the window has been shown. I just tested with the latest cef client - 100.0.22+g4a1240d+chromium-100.0.4896.88 / Chromium 100.0.4896.88.

Note: This issue does not happen when not using offscreen rendering (e.g. cefclient.exe --multi-threaded-message-loop --no-sandbox) presumably because the bounds are known earlier.

@magreenblatt
Copy link
Collaborator Author

Issue #3321 was marked as a duplicate of this issue.

@magreenblatt
Copy link
Collaborator Author

This is something that needs to be fixed in the client, possibly with the assistance of new/modified CEF API.

@magreenblatt
Copy link
Collaborator Author

  • changed kind from "bug" to "enhancement"
  • changed title from "Windows IME popup displayed in wrong position when using offscreen rendering" to "Windows: Fix IME popup and selection issues with OSR"
  • changed component from "Unclassified" to "Framework"

@magreenblatt
Copy link
Collaborator Author

See also issue #3306

@magreenblatt
Copy link
Collaborator Author

Issue #2348 was marked as a duplicate of this issue.

@magreenblatt
Copy link
Collaborator Author

windows: cefclient: Fix crash when triggering IME popup (see issue #3313)

→ <<cset 9f7a59536c21 (bb)>>

@magreenblatt
Copy link
Collaborator Author

Testing with OSR at current master (M105), I am able to reproduce this issue when typing ‘a' in the search field with Japanese + Hiragana on first launch of cefclient only. It also reproduces with Chinese input on first launch (instructions from issue #3306). It does not reproduce (popup is correctly placed) on the 2nd+ time typing in the search field.

@magreenblatt
Copy link
Collaborator Author

  • changed component from "Framework" to "SampleApps"
  • changed kind from "enhancement" to "bug"
  • changed priority from "major" to "minor"
  • changed title from "Windows: Fix IME popup and selection issues with OSR" to "cefclient: Windows: Japanese IME popup is placed incorrectly with OSR"

@magreenblatt
Copy link
Collaborator Author

Screenshot of incorrect placement attached.

@magreenblatt
Copy link
Collaborator Author

  • set attachment to "japanese_input.png"

@magreenblatt
Copy link
Collaborator Author

Original comment by Andrew Smith (Bitbucket: Andrew Smith).


If you’re changing the title to the specific issue I was reporting then perhaps you might reopen 3321 since that is no longer related to what you might fix when you get to this one?

@magreenblatt
Copy link
Collaborator Author

windows: cefclient: Fix crash when triggering IME popup (see issue #3313)

→ <<cset 5074b14714c4 (bb)>>

@magreenblatt
Copy link
Collaborator Author

windows: cefclient: Fix crash when triggering IME popup (see issue #3313)

→ <<cset 75c6895fb532 (bb)>>

@magreenblatt
Copy link
Collaborator Author

If you’re changing the title to the specific issue I was reporting then perhaps you might reopen 3321 since that is no longer related to what you might fix when you get to this one?

Agreed and done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report cefclient Related to the cefclient sample app help wanted Issue resolution will likely require community contributions osr Related to off-screen rendering SampleApps Related to sample apps windows Windows platform
Projects
None yet
Development

No branches or pull requests

1 participant