Skip to content

Conversation

arv-aks
Copy link
Contributor

@arv-aks arv-aks commented May 13, 2024

This feature enhances the asset showcase by introducing support for playing audio files (MP3 and WAV formats). Users can now interact with audio assets directly within the showcase interface, enabling them to preview audio content conveniently. Furthermore, this implementation ensures that only one audio file plays at a time, enhancing usability and preventing overlapping audio playback. With this addition, the asset showcase becomes more dynamic and interactive, offering a comprehensive experience for users exploring audio assets.

@chtgupta
Copy link
Owner

Great one @arv-aks! I was expecting this PR from the community. Will do a test run and merge soon.

@arv-aks
Copy link
Contributor Author

arv-aks commented May 17, 2024

Great one @arv-aks! I was expecting this PR from the community. Will do a test run and merge soon.

Thank you! I'm glad I could contribute. Please let me know if there are any issues or further changes needed.

@chtgupta
Copy link
Owner

Hi @arv-aks, can you make the audio element's title (file name) align with other titles? Currently it appears asymmetrical.

image

Also, hovering over the controls results in some overflow. Not sure if that is fixable, or if we can just bear with less controls.

image

@arv-aks
Copy link
Contributor Author

arv-aks commented May 18, 2024

Hi @chtgupta, Thanks for the feedback and addressing the alignment issue with the audio element's title! Regarding your second point about the overflow issue when hovering over the controls, I've looked into it. It seems that the overflow you're observing is related to the volume control of the audio element. Unfortunately, there isn't a straightforward way to hide or modify this control directly through HTML and CSS alone.

Alignment issue is fixed and ready to merge

@chtgupta chtgupta changed the base branch from master to feature/audio May 18, 2024 06:54
@chtgupta chtgupta merged commit 7f4fc5c into chtgupta:feature/audio May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants