Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid log folder directory if colon in database server name #355

Closed
erikbra opened this issue Dec 12, 2018 · 1 comment
Closed

Invalid log folder directory if colon in database server name #355

erikbra opened this issue Dec 12, 2018 · 1 comment
Labels
Bug release-1.0.0 Bugs or issues related to 1.0.0 release

Comments

@erikbra
Copy link
Member

erikbra commented Dec 12, 2018

If the server name includes e.g. tcp: (which is perfectly valid), RoundhousE crashes because it tries to use the colon in the log folder, which is not allowed on windows.

Example run:


 Running RoundhousE v1.0.2.0 against tcp:servername.database.windows.net,1433 - Databasename.
 Looking in ..\db\Databasename for scripts to run.
 Please press enter when ready to kick...
 The directory name is invalid : 'F:\ba1\temp\buildTmp\logs\migrations\Databasename\tcp:servername.database.windows\20181212_081338_1527'
 System.IO.IOException: The directory name is invalid : 'F:\ba1\temp\buildTmp\logs\migrations\Databasename\tcp:servername.database.windows\20181212_081338_1527'
  at System.IO.FileSystem.CreateDirectory(String fullPath)
  at System.IO.Directory.CreateDirectory(String path)
  at roundhouse.infrastructure.filesystem.DotNetFileSystemAccess.create_directory(String directory) in C:\projects\roundhouse\product\roundhouse\infrastructure\filesystem\DotNetFileSystemAccess.cs:line 341
  at roundhouse.runners.RoundhouseMigrationRunner.create_change_drop_folder() in C:\projects\roundhouse\product\roundhouse\runners\RoundhouseMigrationRunner.cs:line 262
  at roundhouse.runners.RoundhouseMigrationRunner.run() in C:\projects\roundhouse\product\roundhouse\runners\RoundhouseMigrationRunner.cs:line 85
  at roundhouse.console.Program.run_migrator(ConfigurationPropertyHolder configuration) in C:\projects\roundhouse\product\roundhouse.console\Program.cs:line 558
  at roundhouse.console.Program.Main(String[] args) in C:\projects\roundhouse\product\roundhouse.console\Program.cs:line 65

@erikbra erikbra added Bug release-1.0.0 Bugs or issues related to 1.0.0 release labels Dec 12, 2018
erikbra added a commit to erikbra/roundhouse that referenced this issue Dec 12, 2018
@erikbra
Copy link
Member Author

erikbra commented Dec 12, 2018

Fixed in #356

@erikbra erikbra closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug release-1.0.0 Bugs or issues related to 1.0.0 release
Projects
None yet
Development

No branches or pull requests

1 participant