Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added triggers folder to run any time folders #102

Merged
merged 2 commits into from
Oct 9, 2017

Conversation

AndersMalmgren
Copy link
Contributor

No description provided.

@ferventcoder
Copy link
Member

Thanks.

@AndersMalmgren
Copy link
Contributor Author

Hi there, have you looked into this pull req? I dont want my customers project to be Dependant on my Github fork :D

@BiggerNoise
Copy link
Member

Anders, we appreciate both your contribution and your patience.

I, for one, am uncomfortable with everyone's corner case having a flag or a folder to support it. It's not that your requests or ideas are inappropriate, it's the cumulative weight of all of them that scares me.

On the team, we have discussed (loosely) how we might extend Mario Pareja's idea of an externally definable workflow to cover cases like this one and the transaction one in your other pull request. The difficulty is that the team has fairly significant outside commitments that makes figuring out how this will really work hard to do.

Unfortunately, I don't have a good answer for you regarding supporting your client with a custom version of RH.

@AndersMalmgren
Copy link
Contributor Author

Thanks I understand your position about adding more folders, like Triggers. What about the out of transaction scope feature? That actually enables new functionally that is not possible todo with current version

@k4gdw
Copy link

k4gdw commented Feb 26, 2013

Doesn't matter much to me one way or the other. But having a triggers folder makes just as much sense as having "indexes", "sprocs", "functions", etc. Use of triggers is hardly an edge case, even though it's best to avoid them, them there are situations where they are simply the best practical solution.

@BiggerNoise BiggerNoise merged commit f748133 into chucknorris:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants