Repository navigation
How errors are passed on: messages, causes and aggregates #133
SpiGAndromeda
started this conversation in
General
Replies: 1 comment 1 reply
|
Generally, I agree with the proposed solution. My only question is to clarify |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Error handling has come up in review on #19, #23, #61, #72, #92 and #97. Each time it was settled for that PR only, or left open (#72), and the next review raises it again. This discussion is meant to agree on one set of rules that a review can link to.
What the code and past reviews do today
causecompat-fixture.mjs, test host import of pi's internal modulespath: messagelines and does not keep the original thrown valuectx.ui(notify,setStatus,setWidget), never the consoleAGENTS.md#19 added an
AggregateErrorof the spawn, cleanup and notification failures. #92 replaced it: with a working UI the cleanup failure goes to a notice, and when there is no UI or the notice throws, the result text names both failures (Spawn failed and cleanup failed: <primary>; <cleanup>). The notification failure is dropped. A review on #72 had pointed out that #72's own spawn change drops it from #19'sAggregateErrorwithout a note. That thread has no reply, and review F-01 on #92 raised it again.Open questions
causewhen it only helps a developer debugging, and the message already says what failed? test: load pi through its public entry points in the test hosts #97 says no; a review on test: load pi through its public entry points in the test hosts #97 asked for it.cause; spawn's error results carry the error's message, not itscause.CONTRIBUTING.mdordocs/architecture.md?Proposal
causewhen wrapping.All reactions