Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

missing response.setEncoding('utf8') #119

Open
wants to merge 1 commit into from

1 participant

@jackyz

I thought oauth2.js missed one line response.setEncoding('utf8'), the oauh.js has this line.

But missing the line, the chunk is a buffer, and result+= chunk will cause encoding problem. Because one char in utf8 (one char in may bytes) maybe separated into two buffers. and result+=chunk implies chunk convert to string first, so one good char becomes two broken char.

This is the same problem as issues #118, and I think pull request #80 is a good idea, but it should be applied to oauth2.js as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 28, 2012
  1. @jackyz

    add response.setEncoding

    jackyz authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  lib/oauth2.js
View
1  lib/oauth2.js
@@ -96,6 +96,7 @@ exports.OAuth2.prototype._request= function(method, url, headers, post_body, acc
}
var request = http_library.request(options, function (response) {
+ response.setEncoding('utf8');
response.on("data", function (chunk) {
result+= chunk
});
Something went wrong with that request. Please try again.