Enable kube-proxy replacement if no kube-proxy is detected in a cluster #1039
Conversation
|
Hi Team, |
|
Commit 4bc875b does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Previously, Cilium-CLI won’t enable kube-proxy by default automatically if no kube-proxy has been installed in the cluster. This patch will detect kube-proxy installation in the cluster automatically and it’ll set the helm values kubeProxyReplacement=strict, k8sServiceHost, and k8sServicePort if there were no kube-proxy. Fixes: cilium#1004 Signed-off-by: shankeerthan-kasilingam <shankeerthan1995@gmail.com>
| } | ||
|
|
||
| for _, ds := range dsList.Items { | ||
| if strings.Contains(ds.Name, "kube-proxy") { |
There was a problem hiding this comment.
maybe we should use if ds.Nmae == "kube-proxy" instead of strings.Contains?
There was a problem hiding this comment.
@cmssczy thanks for the suggestion. Yes, the Kube-proxy auto-detection may take a different DaemonSet as Kube-Proxy if they also contain "kube-proxy". Just for curiosity, have you found such cases like that? @brb wdyt?
There was a problem hiding this comment.
I've only seen "kube-proxy", so the suggested change makes sense to me.
There was a problem hiding this comment.
Thanks @brb. If you think it's to better to change now, I can create a git Issue for that since we already merged this branch? (I can fix that too)
There was a problem hiding this comment.
I think it faster to create a PR than an issue, so I'd go with a fix. Thanks.
Previously, Cilium-CLI won’t enable kube-proxy by default automatically if no kube-proxy has been installed in the cluster. This patch will detect kube-proxy installation in the cluster automatically and it’ll set the helm value kubeProxyReplacement=strict if there were no kube-proxy.
Fixes: #1004