[connectivity] add container name for health tests #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
requested changes
Jan 26, 2023
|
@fl64 You'll need to import the defaults package as well, it seems. Please also squash the commits into one. |
|
@tklauser Sorry, my fault, I missed it. |
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
fl64
force-pushed
the
add-container-name-for-health-checks
branch
from
ea08154 to
e95cb4a
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments it is possible to use ds cilium with multiple containers (e.g. kube-rbac-proxy) in these cases the health tests do not work correctly.
For example: