Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes versioncheck for l7 proxy disabling with wireguard encryption #1529

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

ShiroDN
Copy link
Contributor

@ShiroDN ShiroDN commented Apr 21, 2023

This commit fixes versioncheck so that it includes patch versions of cilium 1.13.x. Versions 1.13.x triggers en error:

level=fatal msg="Wireguard (--enable-wireguard) is not compatible with L7 proxy (--enable-l7-proxy)" subsys=daemon

Fixes: 64924bf ("enabled l7Proxy & removed err.log message for WireGuard")

This commit fixes versioncheck so that it includes patch versions of cilium 1.13.x. Versions 1.13.x triggers en error:

level=fatal msg="Wireguard (--enable-wireguard) is not compatible with L7 proxy (--enable-l7-proxy)" subsys=daemon

Fixes: 64924bf ("enabled l7Proxy & removed err.log message for WireGuard")

Signed-off-by: Tomas Leypold <tomas@leypold.cz>
@ShiroDN ShiroDN requested a review from a team as a code owner April 21, 2023 15:34
@ShiroDN ShiroDN requested a review from squeed April 21, 2023 15:34
@ShiroDN ShiroDN temporarily deployed to ci April 21, 2023 15:34 — with GitHub Actions Inactive
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 26, 2023
@tklauser tklauser merged commit e5368a1 into cilium:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants