Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI test resources unique for retries. #1699

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

viktor-kurchenko
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko commented Jun 4, 2023

Sometimes resources cleanup for CI tests might fail (due to the different reasons).
Then user won't be able to retry a pipeline till Custodian drops the provisioned resources.

Current PR adds pipeline retry counter to the resource names to avoid conflicts.

Signed-off-by: viktor-kurchenko <69600804+viktor-kurchenko@users.noreply.github.com>
@viktor-kurchenko viktor-kurchenko requested review from a team as code owners June 4, 2023 18:52
@viktor-kurchenko viktor-kurchenko requested review from aanm and nebril June 4, 2023 18:52
@viktor-kurchenko viktor-kurchenko temporarily deployed to ci June 4, 2023 18:52 — with GitHub Actions Inactive
@viktor-kurchenko
Copy link
Contributor Author

Here is the PR from the origin repo were all the tests passed: #1700
@aanm @nebril ^^^

@viktor-kurchenko viktor-kurchenko added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@tklauser tklauser merged commit 41e2538 into cilium:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants