Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1829

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Update README.md #1829

merged 1 commit into from
Jul 17, 2023

Conversation

saintdle
Copy link
Contributor

corrected helm list command

@saintdle
Update README.md
0146021 
corrected ```helm list``` command 

Signed-off-by: Dean <22192242+saintdle@users.noreply.github.com>
@saintdle saintdle requested a review from a team as a code owner July 12, 2023 16:04
@saintdle saintdle requested a review from asauber July 12, 2023 16:04
@saintdle saintdle temporarily deployed to ci July 12, 2023 16:04 — with GitHub Actions Inactive
@asauber
Copy link
Member

asauber commented Jul 14, 2023 •
edited
Loading

In the context of this example, the Helm release name will always be "cilium". I don't see this change as needed.

I appreciate the attention to detail here. I'm going to close this PR in favor of simplicity in the front-matter examples.

@asauber asauber closed this Jul 16, 2023
@saintdle
Copy link
Contributor Author

In the context of this example, the Helm release name will always be "cilium". I don't see this change as needed.

I appreciate the attention to detail here. I'm going to close this PR in favor of simplicity in the front-matter examples.

Sure makes sense, however the provided command in the docs is incorrect. If the release name is always cilium, and you want to run the list command to only show that release, you need to use the --filter argument. You cannot simply declare the name of the release.

https://helm.sh/docs/helm/helm_list/

@asauber asauber reopened this Jul 17, 2023
@asauber asauber temporarily deployed to ci July 17, 2023 15:41 — with GitHub Actions Inactive
@michi-covalent
Copy link
Contributor

this is a readme file only change, not need to wait for the full tests. merging ✅

@michi-covalent michi-covalent merged commit ee72337 into cilium:main Jul 17, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 17, 2023
Merged
@saintdle saintdle deleted the patch-1 branch July 18, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saintdle @asauber @michi-covalent