Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdump - Add --cilium-operator-namespace option #780

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

jaredledvina
Copy link
Contributor

Small pull request to allow passing in --cilium-operator-namespace to support use cases where the cilium-operator runs in a different namespace than the cilium-agent.

Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>
@jaredledvina jaredledvina requested a review from a team as a code owner April 6, 2022 13:43
@jaredledvina jaredledvina temporarily deployed to ci April 6, 2022 13:43 Inactive
@michi-covalent michi-covalent requested review from aanm and tklauser April 6, 2022 20:39
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. added @aanm and @tklauser as reviewers as well just to double check it's ok to run operator and cilium in different namespaces.

@aanm
Copy link
Member

aanm commented Apr 7, 2022

@jaredledvina currently it's not supported installing Cilium Operator on a different namespace other than Cilium. How did you install Cilium Operator in a way that it was running on a different namespace?

@jaredledvina
Copy link
Contributor Author

Hey @aanm, thanks for the review!

Perhaps I should have renamed this PR to avoid suggesting this is an officially supported configuration. I understand that having the operator and agent in different namespaces isn't officially supported.

In setups where that is the case, it'd be great to have this as an option so that sysdump's do work. This does default to keeping the same namespace as the agent too.

How did you install Cilium Operator in a way that it was running on a different namespace?

We have a chart that differs from what exists in cilium/cilium in this regard.

@jaredledvina jaredledvina changed the title Support operator running in a different namespace sysdump - Add --cilium-operator-namespace option Apr 8, 2022
@michi-covalent michi-covalent merged commit aad7a72 into cilium:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants