Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect Kubernetes Endpoints in sysdump #794

Merged
merged 1 commit into from
Apr 14, 2022
Merged

feat: collect Kubernetes Endpoints in sysdump #794

merged 1 commit into from
Apr 14, 2022

Conversation

tpfister-form3
Copy link
Contributor

@tpfister-form3 tpfister-form3 commented Apr 14, 2022

Adds the collection of Kubernetes Endpoints to the sysdump command as requested in #520

Signed-off-by: Thorsten Pfister thorsten.pfister@form3.tech

Tested with a local dummy cluster which lead to the additional creation of a k8s-endpoints-20220414-124930.yaml file in the sysdump archive with the following truncated content:

apiVersion: v1
items:
- metadata:
    creationTimestamp: "2022-04-14T10:45:01Z"
    labels:
      endpointslice.kubernetes.io/skip-mirror: "true"
...
<snip>
...
kind: EndpointsList
metadata:
  resourceVersion: "838"

Fixes #520

Signed-off-by: Thorsten Pfister <thorsten.pfister@form3.tech>
@tpfister-form3 tpfister-form3 requested a review from a team April 14, 2022 11:00
@tpfister-form3 tpfister-form3 requested a review from a team as a code owner April 14, 2022 11:00
@tpfister-form3 tpfister-form3 temporarily deployed to ci April 14, 2022 11:00 Inactive
@aanm
Copy link
Member

aanm commented Apr 14, 2022

thank you, this will be useful!

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

We can add EndpointSlice as well, not necessarily required in this PR though.

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tpfister-form3!

@tklauser tklauser merged commit a570404 into cilium:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect Kubernetes Endpoints output in sysdump
4 participants