sysdump: run bugtool even when cilium agent is not running #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that bugtool supports directly generating tar.gz files, do that and remove the explicit extra step. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
When we try and run cilium-bugtool in the agent container, it fails if that container is not running (e.g. because it's in CrashLoopBackoff). So, if that's not running, fall back to an EphemeralContainer or, if that fails, create another pod for exec purposes. Fixes: cilium#871 Signed-off-by: Casey Callendrello <cdc@isovalent.com>
tklauser
requested review from
tklauser and
sayboras
and removed request for
nathanjsweet
sayboras
approved these changes
Jul 14, 2022
|
|
||
| // CreateEphemeralContainer will create a EphemeralContainer (debug container) in the specified pod. | ||
| // EphemeralContainers are special containers which can be added after-the-fact in running pods. They're | ||
| // useful for debugging, either when the target container image doesn't have necessary tools, or because |
There was a problem hiding this comment.
when the target container image doesn't have necessary tools
This could be a good usage for us going forward, a few customers are asking if cilium agent can be with scratch/distroless/minimal base image. Right now, we rely on installing new tools (e.g. tcpdump) some one cases during troubleshooting.
There was a problem hiding this comment.
Indeed, it can be a big space savings, but it will be a long time before we can rely on that feature existing. Right now it's in beta, auto-enabled but behind an optional feature gate. It is scheduled to go GA in 1.25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try and run cilium-bugtool in the agent container, it fails if that container is not running (e.g. because it's in CrashLoopBackoff). So, if that's not running, fall back to an EphemeralContainer or, if that fails, create another pod for exec purposes.
Fixes: #871