Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler more precise way to do the same thing using generic unix tooling #19471

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Simpler more precise way to do the same thing using generic unix tooling #19471

merged 1 commit into from
Apr 20, 2022

Conversation

gavinmcnair
Copy link

@gavinmcnair gavinmcnair commented Apr 18, 2022 •
edited by joestringer
Loading

Just a simple refactor of something which is overcomplicated using generic UNIX tooling.

Its quicker too!

Improve the efficiency of the `k8s-unmanaged.sh` script

@gavinmcnair gavinmcnair requested a review from a team as a code owner April 18, 2022 16:39
@maintainer-s-little-helper
Copy link

Commit 24b2e62b618eb2badc46287b21e6fb8a4a5c3831 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@gavinmcnair gavinmcnair requested a review from joestringer April 18, 2022 16:39
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 18, 2022
joestringer
joestringer approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks! Please sign off your commit message as per the mention from the bot above & re-push the branch, then I think this is good to merge.

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Apr 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 18, 2022
Simpler more precise way to do the same thing using generic unix tooling
1fe3b49 
Signed-off-by: Gavin McNair <gavin.mcnair@kaluza.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 19, 2022
@gavinmcnair
Copy link
Author

I've signed this off. Ready for you guys!

@joestringer joestringer merged commit 8d38ed2 into cilium:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinmcnair @joestringer