-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about conflicting node CIDRs #20204 #20208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One minor correction needed
Thanks for addressing the feedback. Could you please squash all commits into a single commit? |
Signed-off-by: Wojtek Czekalski <me@wczekalski.com>
Done. Thanks everyone for the quick turnaround. Such open source leadership makes me really bullish about the project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Fixes #20204
Signed-off-by: Wojtek Czekalski me@wczekalski.com
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: #20204
I am not a great doc writer but I hope this is enough to get the ball rolling. My team collectively spent 1 day debugging this so I hope we can save others from it.