Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix typo in contrib/script/kind-shell-helpers.sh #21855

Merged
merged 1 commit into from
Oct 25, 2022
Merged

chore: Fix typo in contrib/script/kind-shell-helpers.sh #21855

merged 1 commit into from
Oct 25, 2022

Conversation

sadikkuzu
Copy link
Contributor

@sadikkuzu sadikkuzu commented Oct 23, 2022 •
edited by sayboras

Signed-off-by: SADIK KUZU sadikkuzu@hotmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!
chore: Fix typo in contrib/script/kind-shell-helpers.sh

@sadikkuzu sadikkuzu requested a review from a team as a code owner October 23, 2022 13:00
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 23, 2022
sayboras
sayboras approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and lgtm 💯

@sayboras
Copy link
Member

sayboras commented Oct 23, 2022 •
edited

CI is not required, mark this ready to merge. Updated: Can you update commit message to provide some more details, one liner should be good enough as well.

@sayboras sayboras added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. labels Oct 23, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 23, 2022
@sayboras sayboras removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 23, 2022
@sayboras sayboras changed the title fix: Fix typos chore: Fix typo in contrib/script/kind-shell-helpers.sh Oct 23, 2022
@sadikkuzu
Copy link
Contributor Author

sadikkuzu commented Oct 23, 2022 •
edited

CI is not required, mark this ready to merge. Updated: Can you update commit message to provide some more details, one liner should be good enough as well.

Sure @sayboras 👍🏼
I'm on it It's ok now.

Thanks for the clear and instructive review.

@sadikkuzu
chore: Fix typo in contrib/script/kind-shell-helpers.sh
2259ee0 
Signed-off-by: SADIK KUZU <sadikkuzu@hotmail.com>
@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 24, 2022
@aanm aanm merged commit 2524f98 into cilium:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@aditighag aditighag Awaiting requested review from aditighag aditighag was automatically assigned from cilium/contributing

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sadikkuzu @sayboras @aanm