Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the comparison mode of bool judgment #22922

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

Fish-pro
Copy link
Contributor

@Fish-pro Fish-pro commented Jan 4, 2023

Signed-off-by: Fish-pro zechun.chen@daocloud.io

@Fish-pro Fish-pro requested review from a team as code owners January 4, 2023 09:18
@Fish-pro Fish-pro requested a review from christarazi January 4, 2023 09:18
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 4, 2023
@Fish-pro Fish-pro requested review from jibi and nathanjsweet January 4, 2023 09:18
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 4, 2023
@jibi jibi added the release-note/misc This PR makes changes that have no direct user impact. label Jan 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 4, 2023
@maintainer-s-little-helper
Copy link

Commit 35ec0e2cd0a81a3c9d623742b4a70a9cb908ca62 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 6, 2023
@nathanjsweet
Copy link
Member

/test

@christarazi christarazi added the kind/cleanup This includes no functional changes. label Jan 6, 2023
@christarazi christarazi closed this Jan 6, 2023
@christarazi christarazi reopened this Jan 6, 2023
@christarazi
Copy link
Member

christarazi commented Jan 6, 2023

Closed & reopened because the CI image jobs didn't trigger.

@christarazi
Copy link
Member

christarazi commented Jan 6, 2023

/test

Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With VXLAN

Failure Output

FAIL: Failed to reach 10.0.1.135:80 from testclient-host-57ptf

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.24-kernel-5.4 so I can create one.

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
@christarazi
Copy link
Member

@Fish-pro Please only push to rebase if it is required. Each time a push occurs, then results of the CI are reset.

@christarazi
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 8, 2023
@aditighag aditighag merged commit e0eaa66 into cilium:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants