Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated logs for test-output.log #24171

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Fix duplicated logs for test-output.log #24171

merged 1 commit into from
Mar 9, 2023

Conversation

romanspb80
Copy link
Contributor

This patch avoid duplicated info in the test-output.log

Fixes: #18515

@romanspb80
Fix duplicated logs for test-output.log
2b70b03 
This patch avoide duplicated info in the test-output.log

Fixes: cilium#18515

Signed-off-by: Roman Ptitcyn <romanspb@yahoo.com>
@romanspb80 romanspb80 requested a review from a team as a code owner March 4, 2023 18:28
@romanspb80 romanspb80 requested a review from tklauser March 4, 2023 18:28
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 4, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 4, 2023
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 6, 2023
@aanm
Copy link
Member

aanm commented Mar 6, 2023

/test

@tklauser tklauser requested a review from nebril March 8, 2023 09:34
nebril
nebril approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This change definitely helps.

I am not sure whether there are other occurrences where SkipLog should also be used, but after cursory looking through kubectl.go your change seem to be fixing the most glaring problem.

lets shipit

@tklauser tklauser removed their request for review March 8, 2023 10:50
@romanspb80
Copy link
Contributor Author

Thanks for the PR! This change definitely helps.

I am not sure whether there are other occurrences where SkipLog should also be used, but after cursory looking through kubectl.go your change seem to be fixing the most glaring problem.

lets shipit

Thanks Maciej

@aanm aanm merged commit 853ec10 into cilium:master Mar 9, 2023
@tommyp1ckles tommyp1ckles mentioned this pull request Mar 11, 2023
Closed
4 tasks
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 20, 2023
Merged
5 tasks
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 20, 2023
Merged
9 tasks
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 23, 2023
Merged
29 tasks
@youngnick youngnick added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.11 labels Mar 23, 2023
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 labels Apr 7, 2023
@michi-covalent michi-covalent mentioned this pull request Apr 14, 2023
Merged
@michi-covalent michi-covalent mentioned this pull request Apr 14, 2023
Merged
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

Assignees
No one assigned
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
cilium v1.13.2
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: do not store logs which are stored in separate files in test-output.log
6 participants
@romanspb80 @aanm @nebril @jibi @NikAleksandrov @youngnick